Add: ConfigManagerのマイグレーション時にスナップショットテストを追加 (VOICEVOX#2357)

Hiroshiba · Dec 21, 2024 · b91830e · b91830e
1 parent 586ac69
commit b91830e
Show file tree

Hide file tree

Showing 3 changed files with 270 additions and 0 deletions.
diff --git a/src/backend/common/ConfigManager.ts b/src/backend/common/ConfigManager.ts
@@ -343,6 +343,12 @@ export abstract class BaseConfigManager {
     this._save();
   }
 
+  /** 全ての設定を取得する。テスト用。 */
+  public getAll(): ConfigType {
+    if (!this.config) throw new Error("Config is not initialized");
+    return this.config;
+  }
+
   private _save() {
     void this.lock.acquire(lockKey, async () => {
       await this.save({

diff --git a/tests/unit/backend/common/__snapshots__/configManager.spec.ts.snap b/tests/unit/backend/common/__snapshots__/configManager.spec.ts.snap
diff --git a/tests/unit/backend/common/configManager.spec.ts b/tests/unit/backend/common/configManager.spec.ts
@@ -1,5 +1,6 @@
 import pastConfigs from "./pastConfigs";
 import configBugDefaultPreset1996 from "./pastConfigs/0.19.1-bug_default_preset.json";
+import { isMac } from "@/helpers/platform";
 import { BaseConfigManager } from "@/backend/common/ConfigManager";
 import { configSchema } from "@/type/preload";
 
@@ -85,6 +86,13 @@ for (const [version, data] of pastConfigs) {
     const configManager = new TestConfigManager();
     await configManager.initialize();
     expect(configManager).toBeTruthy();
+
+    // マイグレーション後のデータが正しいことをスナップショットで確認
+    // NOTE: Macはショートカットキーが異なるためパス
+    // TODO: ConfigManagerにOSを引数指定できるようにしてテストを分ける
+    if (!isMac) {
+      expect(configManager.getAll()).toMatchSnapshot();
+    }
   });
 }