Change messaging format in BgOffsetConsistencyCheck to match KiaiConsistencyCheck #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This just once again updates the way
BgOffsetConsistencyCheckformats its messaging, so that each set of offset groups are under its own sub-issue.Basically just matches how #26 did it since I like that a lot - nice and clean.
Also did a slight refactor for
KiaiConsistencyCheckwhich doesn't change anything besides how it looks on the documentation screen. Just a bit more clear.Screenshots
Showing the BgOffsetConsistencyCheck changes:
How it looks with 3 diffs each with their own offset:
How it looks with 2 diffs with one offset, and 1 diff with another:
Showing
KiaiConsistencyCheckrefactor:Still looks the same as before in the Checks screen:
Updated documentation screen:
