Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warnings for<1ms barline issues #31

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hongaaronc
Copy link
Collaborator

@hongaaronc hongaaronc commented May 6, 2024

Closes #23, #24, #28

Description

In extremely rare cases, barline issues can happen when the notes are perfectly snapped in editor. However, stable has some logic where due to rounding/lack of precision, there actually technically exists a very small unsnap, even though it appears as 0ms in the editor. For examples of these cases, see #23, #24, and #28

Also strangely enough, these rounding errors ONLY exist on stable - they will not occur if the same map is played on Lazer.

This PR will display a warning when this is detected, and asks the user to doublecheck them manually.

I think this is quite important to add, since nowadays more than ever, modders and BNs are becoming more reliant on MV for checking barline issues, and there are still a few that slip through the cracks. This will finally catch those rare edge cases where MV missed them before, and should make it so MV is something we can fully trust in this regard.

Testing

I tested these changes manually on the maps in #23, #24, and #28 . The checks work as expected, and don't seem to appear on other maps where they shouldn't from what I saw.

Screenshots / Examples

0ms last barline hidden detection - Map @ 04:28:703 any diff
image

0ms Double barline detection 1 - Map @ 01:08:944 any diff
image

0ms Double barline detection 2 - Map @ 02:06:856 any diff
image

0ms barline not being affected properly by nearby SV - Map @ 03:12:368 top diff
image

@hongaaronc hongaaronc added the priority:1 important, feels bad without fix label May 6, 2024
@hongaaronc hongaaronc changed the title Add warnings for extremely rare 0ms barline issues Add warnings for<1ms barline issues Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:1 important, feels bad without fix size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsnapped barline not being detected?
1 participant