Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23, #24, #28
Description
In extremely rare cases, barline issues can happen when the notes are perfectly snapped in editor. However, stable has some logic where due to rounding/lack of precision, there actually technically exists a very small unsnap, even though it appears as 0ms in the editor. For examples of these cases, see #23, #24, and #28
Also strangely enough, these rounding errors ONLY exist on stable - they will not occur if the same map is played on Lazer.
This PR will display a warning when this is detected, and asks the user to doublecheck them manually.
I think this is quite important to add, since nowadays more than ever, modders and BNs are becoming more reliant on MV for checking barline issues, and there are still a few that slip through the cracks. This will finally catch those rare edge cases where MV missed them before, and should make it so MV is something we can fully trust in this regard.
Testing
I tested these changes manually on the maps in #23, #24, and #28 . The checks work as expected, and don't seem to appear on other maps where they shouldn't from what I saw.
Screenshots / Examples
0ms last barline hidden detection - Map @
04:28:703
any diff0ms Double barline detection 1 - Map @
01:08:944
any diff0ms Double barline detection 2 - Map @
02:06:856
any diff0ms barline not being affected properly by nearby SV - Map @
03:12:368
top diff