Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#66] Patch generated JSON encoders and decoders #68

Merged
merged 1 commit into from
Mar 25, 2019
Merged

[#66] Patch generated JSON encoders and decoders #68

merged 1 commit into from
Mar 25, 2019

Conversation

chshersh
Copy link
Contributor

Resolves #66
Resolves #63

I also improved documentation a little bit so it's more clear from the README how you should derive FromJSON and ToJSON instances for different data types.

@chshersh chshersh self-assigned this Mar 25, 2019
@chshersh chshersh requested review from arbus and vrom911 March 25, 2019 07:14
vrom911
vrom911 approved these changes Mar 25, 2019
View reviewed changes
Copy link
Contributor

@vrom911 vrom911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great solution!

@vrom911 vrom911 merged commit 2584ec9 into master Mar 25, 2019
@vrom911 vrom911 deleted the chshersh/66-Nested-types-produce-incorrect-decoders branch March 25, 2019 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrom911 vrom911 vrom911 approved these changes

@arbus arbus Awaiting requested review from arbus

Assignees

@chshersh chshersh

Labels
elm json pretty printing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chshersh @vrom911