-
Notifications
You must be signed in to change notification settings - Fork 1
[#1] Add first protocol buffers message and print its serialization to terminal #3
Conversation
@TejasSC I've looked into your error. Unfortunately, I see the same build error 😞 Try for now to build with |
@TejasSC Does it work if you only do something simple with |
Following is after "Registering library for proto-route-0.0.0.." line GHCi, version 8.2.2: http://www.haskell.org/ghc/ :? for help |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really great that current results are possible! Some refactoring is required. But I guess we're moving in the right direction.
CHANGELOG.md
Outdated
========== | ||
|
||
proto-route uses [PVP Versioning][1]. | ||
The change log is available [on GitHub][2]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's actually useful to keep previous content of changelog file.
LICENSE
Outdated
|
||
Copyright (c) 2018 Holmusk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that LICENSE is changed. Could you please return back to previous license?
README.md
Outdated
@@ -1,10 +1 @@ | |||
# proto-route | |||
|
|||
[![Hackage](https://img.shields.io/hackage/v/proto-route.svg)](https://hackage.haskell.org/package/proto-route) | |||
[![MIT license](https://img.shields.io/badge/license-MIT-blue.svg)](https://github.com/holmusk/proto-route/blob/master/LICENSE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous content of README file also can be returned back
stack.yaml
Outdated
@@ -0,0 +1,7 @@ | |||
resolver: lts-11.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you could try to use latest resolver from Stackage? I guess we figured out that the problem was not in LTS. So I think you can use newer GHC version. And also you can remove those packages from extra-deps
that are in the LTS resolver you're going to use.
app/Main.hs
Outdated
-- Value of generated msg, and its serialized representation | ||
execStatement "sr" | ||
execStatement "encodeMessage sr" | ||
stopGhci g |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, let's actually move this chunk of code into library
stanza. So Main.hs
file will look like this:
import qualified ProtoRoute
main :: IO ()
main = ProtoRoute.main
This will make executable
stanza very small (almost no dependencies). And we will put all logic into library
. This is better for further modularity.
CHANGELOG.md
Outdated
## Unreleased changes | ||
========== | ||
proto-route uses [PVP Versioning][1]. | ||
The change log is available [on GitHub][2]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[...][1] or [...][2] should point to some links. But links are missing in this file.
CHANGELOG.md
Outdated
@@ -2,3 +2,6 @@ | |||
========== | |||
proto-route uses [PVP Versioning][1]. | |||
The change log is available [on GitHub][2]. | |||
|
|||
[PVP Versioning]: https://pvp.haskell.org/ | |||
[on GitHub]: https://github.com/Holmusk/proto-route/blob/master/CHANGELOG.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, this won't work 😞 The initial content of proto-route
is the following:
Resolves #1
Resolves #2