Skip to content
This repository has been archived by the owner on Nov 13, 2024. It is now read-only.

[#5] Create first draft of Tui with sample process #8

Merged
merged 4 commits into from
Aug 28, 2018

Conversation

TejasSC
Copy link
Contributor

@TejasSC TejasSC commented Aug 23, 2018

Resolves #5

@TejasSC TejasSC self-assigned this Aug 23, 2018
@TejasSC TejasSC requested a review from chshersh August 23, 2018 04:51
@chshersh
Copy link
Contributor

@TejasSC Could you attach some screenshots in the comments to this PR?

@TejasSC TejasSC changed the title [#5] Create first draft of Tui with sample process issue #5 [#5] Create first draft of Tui with sample process Aug 23, 2018
@TejasSC
Copy link
Contributor Author

TejasSC commented Aug 23, 2018

screen shot 2018-08-23 at 2 26 07 pm

screen shot 2018-08-23 at 2 26 26 pm

screen shot 2018-08-23 at 2 26 43 pm

screen shot 2018-08-23 at 2 29 33 pm

@chshersh
Copy link
Contributor

Looks great! For now the goal is to have some edit boxes inside terminal so we can construct message (even if it's just our hardcoded SearchRequest message). Basically, hardcode graphical view for SearchRequest and give ability to change values of the fields and show serialized message.

@TejasSC
Copy link
Contributor Author

TejasSC commented Aug 24, 2018

screen shot 2018-08-24 at 5 37 47 pm

screen shot 2018-08-24 at 5 37 04 pm

screen shot 2018-08-24 at 5 36 21 pm

screen shot 2018-08-24 at 5 36 01 pm

screen shot 2018-08-24 at 5 42 42 pm

@TejasSC
Copy link
Contributor Author

TejasSC commented Aug 24, 2018

screen shot 2018-08-24 at 5 54 37 pm

So now it only works if I type in "SearchRequest" and "query" explicitly as Message name and Field name.

How can I make the serialised representation work so that it doesn't fail on different inputs?

@TejasSC
Copy link
Contributor Author

TejasSC commented Aug 27, 2018

So now whenever I try to edit protobuf2.proto in the Tui.hs file, it never really works due to the following error.
Hence, I still can't generate custom messages now.

I have now added a way for it to recognise the type of value in a field.

screen shot 2018-08-27 at 6 00 58 pm

screen shot 2018-08-27 at 6 00 35 pm

@TejasSC TejasSC force-pushed the dev544-convenient-interface branch from 5584cc4 to 47647e0 Compare August 28, 2018 03:33
@chshersh chshersh merged commit 51ea54e into master Aug 28, 2018
@chshersh chshersh deleted the dev544-convenient-interface branch August 28, 2018 03:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants