-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/suspend-happs #34
Conversation
src/suspend_happs.rs
Outdated
HappAndHost { | ||
happ_id: hha_id.clone(), | ||
holoport_id: holoport_id_holo_hash.clone(), | ||
is_automated: Some(true), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zeeshan595 We need to see that the auto-enable does the same check because we don't want it to auto-enable after it is disabled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be fixed. I moved the susspend logic to be before we fetch happs. That way when we fetch happs to install it should appropriate happs set as disabled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The enable script checks for happs that are disabled automatically and checks for certain conditions. If it passes those conditions it will install the happ.
And right now the check does not do the check that your suspend script does. i.e. check if the invoices are paid.
if you want to do it this way then we wiill have to change the is_automated flag in disable to an enum that is special to this case.
This adds a new feature to
holo-auto-installer
. This will check any unpaid invoice and disable happs that have unpaid invoices to host.