Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/suspend-happs #34

Merged
merged 15 commits into from
Feb 9, 2024
Merged

feat/suspend-happs #34

merged 15 commits into from
Feb 9, 2024

Conversation

zeeshan595
Copy link
Contributor

@zeeshan595 zeeshan595 commented Jan 30, 2024

This adds a new feature to holo-auto-installer. This will check any unpaid invoice and disable happs that have unpaid invoices to host.

@zeeshan595 zeeshan595 changed the title Feat/suspend happs feat/suspend-happs Jan 30, 2024
@zeeshan595 zeeshan595 marked this pull request as ready for review January 31, 2024 11:54
HappAndHost {
happ_id: hha_id.clone(),
holoport_id: holoport_id_holo_hash.clone(),
is_automated: Some(true),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zeeshan595 We need to see that the auto-enable does the same check because we don't want it to auto-enable after it is disabled

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fixed. I moved the susspend logic to be before we fetch happs. That way when we fetch happs to install it should appropriate happs set as disabled

Copy link
Member

@zo-el zo-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The enable script checks for happs that are disabled automatically and checks for certain conditions. If it passes those conditions it will install the happ.

And right now the check does not do the check that your suspend script does. i.e. check if the invoices are paid.

if you want to do it this way then we wiill have to change the is_automated flag in disable to an enum that is special to this case.

@zeeshan595 zeeshan595 merged commit 5258807 into main Feb 9, 2024
2 checks passed
@zeeshan595 zeeshan595 deleted the feat/suspend-happs branch February 9, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants