feat/jurisdiction #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zeeshan595
commented
Feb 22, 2024
•
zeeshan595
commented
- updated presentedhappbundle
- updated hbs script to handle jurisdiction
- updated get_all_published_happ zome call to return jurisdiction & exclude jurisdiction
- fixed install happ (broken because of new jurisdiction variables)
- updated main lib to fetch jurisdiction from hbs and pass it on to uninstall_happs function
- updated uninstall_happs to remove happs that are not in the correct jurisdiction
added 7 commits
February 20, 2024 15:02
- updated presentedhappbundle - updated hbs script to handle jurisdiction - updated get_all_published_happ zome call to return jurisdiction & exclude jurisdiction - fixed install happ (broken because of new jurisdiction variables) - updated main lib to fetch jurisdiction from hbs and pass it on to uninstall_happs function - updated uninstall_happs to remove happs that are not in the correct jurisdiction
zeeshan595
commented
Feb 22, 2024
| @@ -18,7 +15,9 @@ pub async fn suspend_unpaid_happs( | |||
|
|
|||
| let password = | |||
| env::var("DEVICE_SEED_DEFAULT_PASSWORD").expect("DEVICE_SEED_DEFAULT_PASSWORD is not set"); | |||
| let holoport_id_output = Command::new("hpos-config-into-base36-id") | |||
There was a problem hiding this comment.
This change is part of suspend_happs story. We are using hpos_config_path to get the correct path to the executable which will get us the holoport id
zo-el
reviewed
Feb 23, 2024
Co-authored-by: Joel Ulahanna <joelulahanna@gmail.com>
zo-el
requested changes
Mar 18, 2024
Co-authored-by: Joel Ulahanna <joelulahanna@gmail.com>
zo-el
reviewed
Mar 19, 2024
zo-el
reviewed
Mar 19, 2024
zo-el
reviewed
Mar 20, 2024
Co-authored-by: Joel Ulahanna <joelulahanna@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.