Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B 03313 - Update holo-envoy with rsm #37

Merged
merged 66 commits into from
Jan 27, 2021
Merged

Conversation

JettTech
Copy link
Contributor

@JettTech JettTech commented Dec 7, 2020

Updates:

  • switches client protocol to align with holochain wiremessages
  • removes holochain rust references (aside from holochain mock used for tests)
  • adds script to download hha, elemental-chat and servicerlogger dnas
  • adds testing scripts to spin up conductors by exposed client port
  • updates admin calls with rsm counterpart
  • removes admin/agent/list (per agreement to allow the zome call to throw an error in failure case)
  • updates zome_call call signature with rsm updates
  • adds app_info app-interface conductor call
  • replaces mock hha calls with actual calls to rsm updated hha
  • updates servicelogger calls according to DL H0003
  • adds signing work around (temp until wormhole is updated)
  • updates tests

Pairs with Chaperone PR #81
Now pairs with Chaperone v0.3.0

@JettTech JettTech changed the title B 03313 update admin calls B 03313 update envoy for rsm Dec 7, 2020
@JettTech JettTech changed the base branch from develop to rsm-update-2020-11-17 December 7, 2020 14:50
Copy link
Member

@zo-el zo-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few more comments. The only thing I have to get to is tests.

default.nix Outdated Show resolved Hide resolved
src/index.ts Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Show resolved Hide resolved
src/index.ts Show resolved Hide resolved
src/index.ts Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Show resolved Hide resolved
@JettTech JettTech requested a review from zo-el January 22, 2021 22:25
@zo-el
Copy link
Member

zo-el commented Jan 22, 2021

@JettTech what is the status of the tests for this PR and how do I run them?

@JettTech
Copy link
Contributor Author

JettTech commented Jan 25, 2021

@zo-el - You should now be able to just run make test and have all active tests run and succeed.

src/index.ts Outdated Show resolved Hide resolved
zo-el and others added 2 commits January 26, 2021 18:41
Co-authored-by: Robbie Carlton <robbie.carlton@gmail.com>
Copy link
Member

@zo-el zo-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Nice work

A few things we should note:

  • hha app_id is a constant now, but we will get it out in the next ticket.
  • We could have more tests 😅
  • I think we should not be using a ws-wrapper. if you agree we should add it to tech debt.

@JettTech JettTech merged commit a225dd4 into develop Jan 27, 2021
@JettTech JettTech deleted the B-03313-update-admin-calls branch January 27, 2021 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants