-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
B 03313 - Update holo-envoy with rsm #37
Conversation
…Host/holo-envoy into B-03313-update-admin-calls
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few more comments. The only thing I have to get to is tests.
lint, clean up nix files and remove sprintf module
@JettTech what is the status of the tests for this PR and how do I run them? |
@zo-el - You should now be able to just run |
Co-authored-by: Robbie Carlton <robbie.carlton@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Nice work
A few things we should note:
- hha app_id is a constant now, but we will get it out in the next ticket.
- We could have more tests 😅
- I think we should not be using a ws-wrapper. if you agree we should add it to tech debt.
Updates:
admin/agent/list
(per agreement to allow the zome call to throw an error in failure case)zome_call
call signature with rsm updatesapp_info
app-interface conductor call