Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests get_hpos_app_health result #7

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JettTech
Copy link
Contributor

@JettTech JettTech commented Apr 19, 2022

Reason for Update:
Doubts surfaced about how the get_hpos_app_health call would respond if an error occurs with the conductor admin interface as well as how to distinguish between no hpos apps installed and a failed call. The expected behavior is for the value to return an option of None whenever the call fails and Some(<hpos_app_list>) whenever the call succeeds - with an empty hashmap for the value of hpos_app_list as the indicator of no installed happs on the hpos.

Tests Added:

  • Test for ws creation and list_apps call to admin interface
  • Test for a None value for hpos_app_list whenever a ws connection fails
  • Test for a Some value for hpos_app_list whenever a ws connection succeeds

To Test:
cargo run test

@JettTech JettTech requested a review from peeech April 19, 2022 15:06
@JettTech JettTech changed the title add tests for empty hashmap and error cases Add tests get_hpos_app_health result Apr 19, 2022
Copy link
Contributor

@peeech peeech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great, just one thing that README needs updating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants