Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Update:
Doubts surfaced about how the
get_hpos_app_health
call would respond if an error occurs with the conductor admin interface as well as how to distinguish between no hpos apps installed and a failed call. The expected behavior is for the value to return an option ofNone
whenever the call fails andSome(<hpos_app_list>)
whenever the call succeeds - with an empty hashmap for the value ofhpos_app_list
as the indicator of no installed happs on the hpos.Tests Added:
list_apps
call to admin interfaceNone
value forhpos_app_list
whenever a ws connection failsSome
value forhpos_app_list
whenever a ws connection succeedsTo Test:
cargo run test