Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/appagentclient compatibility & node:crypto webpack #101

Merged
merged 4 commits into from
Sep 6, 2023
Merged

Fix/appagentclient compatibility & node:crypto webpack #101

merged 4 commits into from
Sep 6, 2023

Conversation

mattyg
Copy link
Contributor

@mattyg mattyg commented Jul 27, 2023 •
edited
Loading

  • Fix compatibility of WebSdkApi with AppAgentClient interface by setting the field myPubKey
  • Fix building of library by specifying the webpack external lib node:crypto

@mattyg
Copy link
Contributor Author

mattyg commented Jul 27, 2023 •
edited
Loading

hey @robbiecarlton just two small fixes -- with these its working well for me locally!

@mattyg mattyg mentioned this pull request Jul 27, 2023
Merged
robbiecarlton
robbiecarlton approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@robbiecarlton robbiecarlton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, merging now, thanks @mattyg!

@robbiecarlton robbiecarlton changed the base branch from develop to pubkey September 6, 2023 20:56
@robbiecarlton robbiecarlton merged commit cbd940f into Holo-Host:pubkey Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robbiecarlton robbiecarlton robbiecarlton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattyg @robbiecarlton