Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CI.yml #9

Merged
merged 1 commit into from
Aug 26, 2021
Merged

add CI.yml #9

merged 1 commit into from
Aug 26, 2021

Conversation

kdw503
Copy link
Contributor

@kdw503 kdw503 commented Aug 26, 2021

add CI #4

@timholy
Copy link
Member

timholy commented Aug 26, 2021

Should we merge this as-is? I notice CI didn't run, but maybe that will only happen once this is merged.

Will it need secrets? This repo is private (though I guess there's no particularly good reason for that, we could just open it).

@kdw503
Copy link
Contributor Author

kdw503 commented Aug 26, 2021

That's weird. This CI should be activated with pull_request because this includes below lines in it. May be because this is the first time we add this CI?

on:
    pull_request:

And, I don't think this needs any secrets because it looks this doesn't have any private dependent packages, right?

@timholy
Copy link
Member

timholy commented Aug 26, 2021

I just made it public. I'll merge this and then we'll see if it runs next time.

@timholy timholy merged commit 759eb48 into master Aug 26, 2021
@timholy timholy deleted the dwk/ci branch August 26, 2021 15:31
@timholy
Copy link
Member

timholy commented Aug 26, 2021

Oh, it's because it's in the .github directory but not workflows.

@timholy
Copy link
Member

timholy commented Aug 26, 2021

It's running now, yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants