[WIP] Add rotation moves + make a new folder for path changes #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14 +/- ##
=======================================
Coverage 65.00% 65.00%
=======================================
Files 5 8 +3
Lines 180 180
=======================================
Hits 117 117
Misses 63 63 ☔ View full report in Codecov by Sentry. |
|
I started using this package. Is really convenient, great. However, the functions defined in this PR are definitely something I'm kinda doing in a more cumbersome way 😄 . How can I help to make this go into master ? |
|
More use cases would be nice, I wrote these path changes for myself but not 100% sure how people are using them / if there is a more general strategy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves each path change into its own file for simplicity / searchability. It will also add three new moves:
RotateCamera(duration, axis, angle)- rotate the camera aroundaxisOrbitCamera(duration, axis, angle)- similar toRotateCamerain implementation, but rotates the camera around itslookatwhile keeping thatlookatconstant.CompoundMove: apply multiple moves simultaneously, so you can e.g. rotate the camera while translating. Moves are applied in order.