Skip to content

Commit

Permalink
feat(control): Do not show CO aliases in developer tools window
Browse files Browse the repository at this point in the history
This hides aliases in the control model. Aliases are only for backwards
compatibility, so this reduces the risk that mapping developers use
these COs for new mappings.

This also removes a bunch of CO deprecation warnings when opening the
developer tools window or starting the QML interface.
  • Loading branch information
Holzhaus committed Nov 5, 2023
1 parent e3e0f6e commit b2786a1
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions src/control/controlmodel.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ ControlModel::ControlModel(QObject* pParent)
// Add all controls to Model
const QList<QSharedPointer<ControlDoublePrivate>> controlsList =
ControlDoublePrivate::getAllInstances();
const QHash<ConfigKey, ConfigKey> controlAliases =
ControlDoublePrivate::getControlAliases();

for (const QSharedPointer<ControlDoublePrivate>& pControl : controlsList) {
if (!pControl) {
Expand All @@ -26,14 +24,6 @@ ControlModel::ControlModel(QObject* pParent)
addControl(pControl->getKey(),
pControl->name(),
pControl->description());

ConfigKey aliasKey = controlAliases[pControl->getKey()];
if (aliasKey.isValid()) {
addControl(aliasKey,
pControl->name(),
QStringLiteral("Alias for ") + pControl->getKey().group +
pControl->getKey().item);
}
}
}

Expand Down

0 comments on commit b2786a1

Please sign in to comment.