Skip to content

Commit

Permalink
fix(coreservices): Remove obsolete getLV2Backend() method
Browse files Browse the repository at this point in the history
This method is obsolete. It's never used in production code and always
returns `nullptr` because the `m_pLV2Backend` member of `CoreServices`
is never set.
  • Loading branch information
Holzhaus committed Sep 26, 2023
1 parent aa5ed24 commit d8fa6f5
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 8 deletions.
7 changes: 0 additions & 7 deletions src/coreservices.h
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ class ControllerManager;
class VinylControlManager;
class TrackCollectionManager;
class Library;
class LV2Backend;

namespace mixxx {

Expand Down Expand Up @@ -82,10 +81,6 @@ class CoreServices : public QObject {
return m_pVCManager;
}

LV2Backend* getLV2Backend() const {
return m_pLV2Backend;
}

std::shared_ptr<EffectsManager> getEffectsManager() const {
return m_pEffectsManager;
}
Expand Down Expand Up @@ -129,8 +124,6 @@ class CoreServices : public QObject {
std::shared_ptr<SettingsManager> m_pSettingsManager;
std::shared_ptr<mixxx::ControlIndicatorTimer> m_pControlIndicatorTimer;
std::shared_ptr<EffectsManager> m_pEffectsManager;
// owned by EffectsManager
LV2Backend* m_pLV2Backend;
std::shared_ptr<EngineMixer> m_pEngine;
std::shared_ptr<SoundManager> m_pSoundManager;
std::shared_ptr<PlayerManager> m_pPlayerManager;
Expand Down
1 change: 0 additions & 1 deletion src/test/coreservicestest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ TEST_F(CoreServicesTest, DISABLED_TestInitialization) {

EXPECT_NE(pCoreServices->getControllerManager(), nullptr);
EXPECT_NE(pCoreServices->getEffectsManager(), nullptr);
EXPECT_NE(pCoreServices->getLV2Backend(), nullptr);
EXPECT_NE(pCoreServices->getLibrary(), nullptr);
EXPECT_NE(pCoreServices->getPlayerManager(), nullptr);
EXPECT_NE(pCoreServices->getScreensaverManager(), nullptr);
Expand Down

0 comments on commit d8fa6f5

Please sign in to comment.