Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce some clazy issues #7

Closed
wants to merge 2 commits into from
Closed

Introduce some clazy issues #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f998862
GitHub Actions: Improve clazy workflow
Holzhaus Nov 15, 2020
055b9a6
Introduce some clazy issues
Holzhaus Nov 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions .github/workflows/clazy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,18 +8,24 @@ jobs:
clazy:
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v2
- name: Check out repository
uses: actions/checkout@v2
- name: Install build dependencies
run: sudo apt-get update && sudo apt-get install -y --no-install-recommends libavformat-dev libchromaprint-dev libebur128-dev libfftw3-dev libflac-dev libid3tag0-dev liblilv-dev libmad0-dev libmodplug-dev libmp3lame-dev libopus-dev libopusfile-dev libportmidi-dev libprotobuf-dev libqt5opengl5-dev libqt5sql5-sqlite libqt5svg5-dev libqt5x11extras5-dev librubberband-dev libshout3-dev libsndfile1-dev libsoundtouch-dev libsqlite3-dev libtag1-dev libupower-glib-dev libusb-1.0-0-dev libwavpack-dev portaudio19-dev protobuf-compiler qt5-default qtscript5-dev qt5keychain-dev clazy cmake
- name: Build
run: |
mkdir cmake_build
cd cmake_build
# Disable optimizations as workaround for Clang 9 bug: https://bugs.llvm.org/show_bug.cgi?id=45034
cmake -DCMAKE_BUILD_TYPE=Debug -DWARNINGS_FATAL=ON -DOPTIMIZE=off -DBATTERY=ON -DBROADCAST=ON -DBULK=ON -DHID=ON -DLILV=ON -DOPUS=ON -DQTKEYCHAIN=ON -DVINYLCONTROL=ON -DFFMPEG=ON -DKEYFINDER=ON -DLOCALECOMPARE=ON -DMAD=ON -DMODPLUG=ON -DWAVPACK=ON ..
cmake --build . -j $(nproc)
- name: Create Build direcotry
run: mkdir cmake_build
- name: Configure
# Disable optimizations as workaround for Clang 9 bug: https://bugs.llvm.org/show_bug.cgi?id=45034
run: cmake -DCMAKE_BUILD_TYPE=Debug -DWARNINGS_FATAL=ON -DOPTIMIZE=off -DBATTERY=ON -DBROADCAST=ON -DBULK=ON -DHID=ON -DLILV=ON -DOPUS=ON -DQTKEYCHAIN=ON -DVINYLCONTROL=ON -DFFMPEG=ON -DKEYFINDER=ON -DLOCALECOMPARE=ON -DMAD=ON -DMODPLUG=ON -DWAVPACK=ON ..
working-directory: cmake_build
env:
LD: clang++
CC: clang
CXX: clazy
- name: Set up problem matcher
uses: ammaraskar/gcc-problem-matcher@master
- name: Build
run: cmake --build . -j $(nproc)
working-directory: cmake_build
env:
CLAZY_CHECKS: level1,no-rule-of-two-soft,no-non-pod-global-static,no-qproperty-without-notify,no-wrong-qevent-cast
2 changes: 1 addition & 1 deletion src/engine/sync/enginesync.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,7 +477,7 @@ Syncable* EngineSync::pickNonSyncSyncTarget(EngineChannel* pDontPick) const {

bool EngineSync::otherSyncedPlaying(const QString& group) {
bool othersInSync = false;
for (Syncable* theSyncable : qAsConst(m_syncables)) {
for (Syncable* theSyncable : m_syncables) {
bool isSynchonized = theSyncable->isSynchronized();
if (theSyncable->getGroup() == group) {
if (!isSynchonized) {
Expand Down
2 changes: 1 addition & 1 deletion src/track/serato/markers2.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,7 +567,7 @@ QByteArray SeratoMarkers2::dumpID3() const {
QList<SeratoMarkers2EntryPointer> SeratoMarkers2::findEntriesByType(
SeratoMarkers2Entry::TypeId typeId) const {
QList<SeratoMarkers2EntryPointer> entriesFound;
for (const auto& pEntry : qAsConst(m_entries)) {
for (const auto& pEntry : m_entries) {
VERIFY_OR_DEBUG_ASSERT(pEntry) {
continue;
}
Expand Down