Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bottles-failure-and-output: group failure and output steps #289

Merged

Conversation

mohzulfikar
Copy link
Contributor

Following the discussion on Homebrew/gsoc#44 and Homebrew/brew#11101, This PR will create a composite action to group outputs after creating a bottles.

Any feedback would be appreciated. Thank you.

bottles-failure-and-output/README.md Outdated Show resolved Hide resolved
bottles-failure-and-output/action.yml Outdated Show resolved Hide resolved
bottles-failure-and-output/action.yml Outdated Show resolved Hide resolved
bottles-failure-and-output/action.yml Outdated Show resolved Hide resolved
Copy link
Member

@Rylan12 Rylan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good start!

bottles-failure-and-output/README.md Outdated Show resolved Hide resolved
bottles-failure-and-output/action.yml Outdated Show resolved Hide resolved
bottles-failure-and-output/action.yml Outdated Show resolved Hide resolved
mohzulfikar and others added 2 commits July 6, 2022 22:51
Update usage example on readme

Co-authored-by: Rylan Polster <rslpolster@gmail.com>
@mohzulfikar
Copy link
Contributor Author

Hello there, any other suggestion for this PR?

Co-authored-by: Sean Molenaar <SMillerDev@users.noreply.github.com>
Copy link
Member

@Rylan12 Rylan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Shall we merge this?

@mohzulfikar
Copy link
Contributor Author

Sure, If there's no other thing to discuss. I want to modify the other action to use this too.

@carlocab
Copy link
Member

The touch, cat, rm is a common pattern. It might be nice to have an action that takes a list of files and a working directory and then does that with each of them.

@mohzulfikar
Copy link
Contributor Author

Did you mean about making a composite action that could act as a "template" for steps that contains touch, cat, and rm commands?

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants