Skip to content

Commit

Permalink
extend/ENV/super: use brew libs for some Python packages
Browse files Browse the repository at this point in the history
This avoids using bundled libraries for:

* `hidapi`[^1]
* `pynacl`[^2]

The build should now fail if dependency is missing.

[^1]: https://github.com/trezor/cython-hidapi/blob/0.14.0.post2/setup.py#L229
[^2]: https://github.com/pyca/pynacl/blob/1.5.0/setup.py#L71-L73
  • Loading branch information
cho-m committed Oct 12, 2024
1 parent 3291ad4 commit 8623f97
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions Library/Homebrew/extend/ENV/super.rb
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,10 @@ def setup_build_environment(formula: nil, cc: nil, build_bottle: false, bottle_a
# Prevent Go from automatically downloading a newer toolchain than the one that we have.
# https://tip.golang.org/doc/toolchain
self["GOTOOLCHAIN"] = "local"
# Prevent Python packages from using bundled libraries.
# Currently for hidapi and pynacl
self["HIDAPI_SYSTEM_HIDAPI"] = "1"
self["SODIUM_INSTALL"] = "system"

Check warning on line 99 in Library/Homebrew/extend/ENV/super.rb

View check run for this annotation

Codecov / codecov/patch

Library/Homebrew/extend/ENV/super.rb#L98-L99

Added lines #L98 - L99 were not covered by tests

set_debug_symbols if debug_symbols

Expand Down

0 comments on commit 8623f97

Please sign in to comment.