Homebrew 3.0.0 deprecations/disables

[MikeMcQuaid]

Do the usual deprecate/disable dance for Homebrew 3.0.0.

[BrewTestBot]

Review period will end on 2021-01-25 at 15:00:10 UTC.

[Rylan12]

What a beauty!

---

I just merged a new uncommented deprecation in #10370 to deprecate the brew release-notes command. I'm happy to push the change but it requires a rebase and I don't want to force-push over your stuff here as I'm not totally sure what your workflow is for these.

[jonchang]

We probably don't want to delete brew pr-pull given that our bottle publishing workflow relies on it.

[EricFromCanada]

Can also drop the special reformatting commands in parser.rb lines 196 & 346.

[MikeMcQuaid]

I just merged a new uncommented deprecation in #10370 to deprecate the brew release-notes command. I'm happy to push the change but it requires a rebase and I don't want to force-push over your stuff here as I'm not totally sure what your workflow is for these.

@Rylan12 Done!

Can also drop the special reformatting commands in parser.rb lines 196 & 346.

@EricFromCanada Done!

We probably don't want to delete brew pr-pull given that our bottle publishing workflow relies on it.

@jonchang Come on, live a little (fixed 😅)!

[MikeMcQuaid]

Note to self: after this is merged I/we should create an issue to delete everything remaining in Library/Homebrew/cask/cmd (and corresponding tests) and fix the code reliant on it.

[Rylan12]

I took a glance through everything here and it looks good to me. I didn't check the cask command stuff really because I'm much less familiar with that, but all the things I was involved in (i.e. release-notes, Homebrew::CLI::Parser, Completions, etc.) look good.

Any estimate for when this will be merged? I'm asking because I'm thinking about the completion PRs that are coming. It doesn't really matter whether this is merged before or after those PRs, but just keep in mind that whichever is merged second will need to rebase after the first is merged to not break the brew man output.

[BrewTestBot]

Review period ended.

[MikeMcQuaid]

Any estimate for when this will be merged?

"Beginning of February" most likely.

It doesn't really matter whether this is merged before or after those PRs, but just keep in mind that whichever is merged second will need to rebase after the first is merged to not break the brew man output.

Merged yours, I'm happy to rebase (but thanks for thinking about it!).

I assume this is an editor thing. I'm not opposed to it but it does make the diffs a little harder to read (can't easily tell if lines were added/removed). Not a huge deal, but I'd rather we be consistent about this in the future. I feel like I've seen it flip-flop several times.

Yeh, I'll extract this into another PR.

[MikeMcQuaid]

Yeh, I'll extract this into another PR.

#10429

[MikeMcQuaid]

Any estimate for when this will be merged?

Next week.

[md5]

Apologies if I should have had an easier time finding this, but is there any documentation about the removal of the :java requirement type?

I was just trying to see if it was possible to install the gradle formula without installing openjdk since I want it to use the Oracle JDK I already have installed, but brew audit didn't like when I tried to make "openjdk" a :recommended formula since it's in homebrew-core.

I then saw that a JavaRequirement existed at some point that looked like just what I wanted, but it looks like this commit removed it 😞

Any advice on how one can successfully use the Oracle JDK and avoid installing openjdk when it isn't needed would also be greatly appreciated.

[jonchang]

Please use our discussions forum for general questions, thanks! https://github.com/Homebrew/discussions/discussions

[MikeMcQuaid]

Apologies if I should have had an easier time finding this, but is there any documentation about the removal of the :java requirement type?

The release notes.

I was just trying to see if it was possible to install the gradle formula without installing openjdk since I want it to use the Oracle JDK I already have installed

It is not. We don't use the system Java any more.

Any advice on how one can successfully use the Oracle JDK and avoid installing openjdk when it isn't needed would also be greatly appreciated.

You'll need to create your own formula.