Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cellars: write tag specific cellars #10449

Merged
merged 5 commits into from
Jan 28, 2021
Merged

cellars: write tag specific cellars #10449

merged 5 commits into from
Jan 28, 2021

Conversation

MikeMcQuaid
Copy link
Member

Take two of #10377

iMichka and others added 5 commits January 28, 2021 13:19
@iMichka @MikeMcQuaid
cellars: write tag specific cellars
de2e309 
With Homebrew#10186 now merged, the tag specific cellar information is being read by brew.
This PR (once merged) will start adding the cellar information for each tag instead
of having a single cellar line on the top of the bottle block.

Each new CI build in homebrew-core will slowly start migrating the cellar lines to
the right place. If keep-old is used, the old "all tag" cellar line is removed and
added to each tag.
@MikeMcQuaid
dev-cmd/bottle_spec: add another integration test on macOS.
902993a
@iMichka @MikeMcQuaid
bottle_spec: run generate_sha256_line test on mac too
838cf2f
@iMichka @MikeMcQuaid
rubocop: do not complain for too long sha256 lines in bottle blocks
e142dd3
@MikeMcQuaid
Fixup brew bottle (and tests) for Homebrew#10447.
4afebd2
@MikeMcQuaid MikeMcQuaid added do not merge critical Critical change which should be shipped as soon as possible. labels Jan 28, 2021
@MikeMcQuaid MikeMcQuaid requested a review from iMichka January 28, 2021 15:03
BrewTestBot
BrewTestBot previously approved these changes Jan 28, 2021
View reviewed changes
@iMichka
Copy link
Member

iMichka commented Jan 28, 2021

No need for critical, this can only be merged after a release has been made with the reading code.

@iMichka iMichka removed the critical Critical change which should be shipped as soon as possible. label Jan 28, 2021
@BrewTestBot BrewTestBot dismissed their stale review January 28, 2021 15:18

Review period has not ended yet.

@BrewTestBot
Copy link
Member

Review period will end on 2021-01-29 at 15:03:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Jan 28, 2021
@MikeMcQuaid
Copy link
Member Author

No need for critical, this can only be merged after a release has been made with the reading code.

@iMichka I have released 2.7.7 now.

@MikeMcQuaid
Copy link
Member Author

@iMichka When works for me to merge this such that you can babysit it a bit? Tomorrow morning?

@iMichka
Copy link
Member

iMichka commented Jan 28, 2021

Actually right now, I have 1h30 in front of me before dinner, and more hours this evening before going to bed :)

@iMichka iMichka added critical Critical change which should be shipped as soon as possible. and removed do not merge labels Jan 28, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@iMichka iMichka removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Jan 28, 2021
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Jan 28, 2021
@iMichka iMichka merged commit 61e3865 into Homebrew:master Jan 28, 2021
@iMichka iMichka deleted the bottle-write branch January 28, 2021 17:09
@iMichka iMichka mentioned this pull request Jan 28, 2021
Closed
@sjackman sjackman mentioned this pull request Jan 28, 2021
Closed
8 tasks
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Feb 28, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iMichka iMichka iMichka approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MikeMcQuaid @iMichka @BrewTestBot