formula_auditor: audit for deprecated dependencies #12770

carlocab · 2022-01-21T14:37:11Z

Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same change?
Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your changes? Here's an example.
Have you successfully run brew style with your changes locally?
Have you successfully run brew typecheck with your changes locally?
Have you successfully run brew tests with your changes locally?

This will probably require a bunch of changes in Homebrew/core.

BrewTestBot · 2022-01-21T14:37:28Z

Review period will end on 2022-01-24 at 14:37:11 UTC.

Rylan12 · 2022-01-21T17:11:15Z

Library/Homebrew/formula_auditor.rb

@@ -289,6 +289,12 @@ def audit_deps

          next unless @core_tap

+          if dep_f.deprecated? && !formula.deprecated?
+            problem <<~EOS
+              Dependency '#{dep.name}' is deprecated. Formulae with dependents should not be deprecated.


I think it would be good to clarify that the formula with the audit problem isn't the one that needs changing (probably). Maybe something like this:

Suggested change

Dependency '#{dep.name}' is deprecated. Formulae with dependents should not be deprecated.

Dependency '#{dep.name}' should be un-deprecated because it has dependents that are not deprecated.

Or, I guess:

Suggested change

Dependency '#{dep.name}' is deprecated. Formulae with dependents should not be deprecated.

Dependency '#{dep.name}' is deprecated but has un-deprecated dependents. Either un-deprecate '#{dep.name}' or deprecate its dependents (including '#{formula.name}).

Added a variation of your second suggestion.

BrewTestBot · 2022-01-24T15:06:43Z

Review period ended.

github-actions · 2022-02-15T00:04:45Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

Bo98 · 2022-02-28T03:09:24Z

Library/Homebrew/formula_auditor.rb

@@ -289,6 +289,12 @@ def audit_deps

          next unless @core_tap

+          if dep_f.deprecated? && !formula.deprecated?


Suggested change

if dep_f.deprecated? && !formula.deprecated?

if dep_f.deprecated? && !formula.deprecated? && !formula.disabled?

Wouldn't we want to know when formula are more than deprecated?

What do you mean by "more than deprecated"?

Closes #12748.

Needed for Homebrew/brew#12770.

Needed for Homebrew/brew#12770. Missed from Homebrew#106848.

carlocab · 2022-07-29T12:29:41Z

php@7.4 error fixed in Homebrew/homebrew-core#106849.

ykclient error waiting for Homebrew/homebrew-core#106860. Once that's merged this should be ready to go.

Needed for Homebrew/brew#12770. Missed from #106848. Closes #106860. Signed-off-by: BrewTestBot <1589480+BrewTestBot@users.noreply.github.com>

This formula still has two dependents. Needed for Homebrew/brew#12770.

This formula still has two dependents. Needed for Homebrew/brew#12770. Closes #106888. Signed-off-by: BrewTestBot <1589480+BrewTestBot@users.noreply.github.com>

BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Jan 21, 2022

MikeMcQuaid approved these changes Jan 21, 2022

View reviewed changes

Rylan12 reviewed Jan 21, 2022

View reviewed changes

BrewTestBot added waiting for feedback Merging is blocked until sufficient time has passed for review and removed waiting for feedback Merging is blocked until sufficient time has passed for review labels Jan 23, 2022

BrewTestBot approved these changes Jan 24, 2022

View reviewed changes

github-actions bot added the stale No recent activity label Feb 15, 2022

carlocab removed the stale No recent activity label Feb 17, 2022

Bo98 reviewed Feb 28, 2022

View reviewed changes

Bo98 added the in progress Maintainers are working on this label Mar 14, 2022

carlocab mentioned this pull request Jul 29, 2022

Disable old deprecated formula Homebrew/homebrew-core#103904

Closed

6 tasks

formula_auditor: audit for deprecated dependencies

cbff838

Closes #12748.

BrewTestBot pushed a commit to Homebrew/homebrew-core that referenced this pull request Jul 29, 2022

guile@2: undeprecate

4b9c737

Needed for Homebrew/brew#12770.

BrewTestBot pushed a commit to Homebrew/homebrew-core that referenced this pull request Jul 29, 2022

ilmbase: undeprecate

4c78857

Needed for Homebrew/brew#12770.

BrewTestBot pushed a commit to Homebrew/homebrew-core that referenced this pull request Jul 29, 2022

isl@0.18: undeprecate

e40b600

Needed for Homebrew/brew#12770.

BrewTestBot pushed a commit to Homebrew/homebrew-core that referenced this pull request Jul 29, 2022

jam: undeprecate

7d3209a

Needed for Homebrew/brew#12770.

BrewTestBot pushed a commit to Homebrew/homebrew-core that referenced this pull request Jul 29, 2022

lua@5.1: undeprecate

75b43b9

Needed for Homebrew/brew#12770.

BrewTestBot pushed a commit to Homebrew/homebrew-core that referenced this pull request Jul 29, 2022

mpfi: undeprecate

7e70bb8

Needed for Homebrew/brew#12770.

BrewTestBot pushed a commit to Homebrew/homebrew-core that referenced this pull request Jul 29, 2022

openexr@2: undeprecate

596fc04

Needed for Homebrew/brew#12770.

BrewTestBot pushed a commit to Homebrew/homebrew-core that referenced this pull request Jul 29, 2022

sdl: undeprecate

77db49b

Needed for Homebrew/brew#12770.

BrewTestBot pushed a commit to Homebrew/homebrew-core that referenced this pull request Jul 29, 2022

sdl_image: undeprecate

018fc3f

Needed for Homebrew/brew#12770.

BrewTestBot pushed a commit to Homebrew/homebrew-core that referenced this pull request Jul 29, 2022

sdl_mixer: undeprecate

3d3a352

Needed for Homebrew/brew#12770.

BrewTestBot pushed a commit to Homebrew/homebrew-core that referenced this pull request Jul 29, 2022

sdl_net: undeprecate

01b8c34

Needed for Homebrew/brew#12770.

BrewTestBot pushed a commit to Homebrew/homebrew-core that referenced this pull request Jul 29, 2022

sdl_sound: undeprecate

61a46ec

Needed for Homebrew/brew#12770.

BrewTestBot pushed a commit to Homebrew/homebrew-core that referenced this pull request Jul 29, 2022

sdl_ttf: undeprecate

f9682b7

Needed for Homebrew/brew#12770.

BrewTestBot pushed a commit to Homebrew/homebrew-core that referenced this pull request Jul 29, 2022

tbb@2020: undeprecate

d4903e6

Needed for Homebrew/brew#12770.

BrewTestBot pushed a commit to Homebrew/homebrew-core that referenced this pull request Jul 29, 2022

vtk@8.2: undeprecate

7e0c515

Needed for Homebrew/brew#12770.

formula_auditor: clean up error wording

7c7a92e

carlocab added a commit to carlocab/homebrew-core that referenced this pull request Jul 29, 2022

ykclient: undeprecate

b705623

Needed for Homebrew/brew#12770. Missed from Homebrew#106848.

carlocab mentioned this pull request Jul 29, 2022

ykclient: undeprecate Homebrew/homebrew-core#106860

Closed

6 tasks

carlocab mentioned this pull request Jul 30, 2022

ilmbase, openexr@2: fix livecheck Homebrew/homebrew-core#106865

Closed

6 tasks

BrewTestBot pushed a commit to Homebrew/homebrew-core that referenced this pull request Jul 30, 2022

ykclient: undeprecate

4f7eb27

Needed for Homebrew/brew#12770. Missed from #106848. Closes #106860. Signed-off-by: BrewTestBot <1589480+BrewTestBot@users.noreply.github.com>

carlocab added a commit to carlocab/homebrew-core that referenced this pull request Jul 30, 2022

libelf: undeprecate

8b49f47

This formula still has two dependents. Needed for Homebrew/brew#12770.

carlocab mentioned this pull request Jul 30, 2022

libelf: undeprecate Homebrew/homebrew-core#106888

Closed

6 tasks

BrewTestBot pushed a commit to Homebrew/homebrew-core that referenced this pull request Jul 30, 2022

libelf: undeprecate

ee47f3f

This formula still has two dependents. Needed for Homebrew/brew#12770. Closes #106888. Signed-off-by: BrewTestBot <1589480+BrewTestBot@users.noreply.github.com>

carlocab enabled auto-merge July 30, 2022 05:15

carlocab merged commit e217fd3 into Homebrew:master Jul 30, 2022

carlocab deleted the deprecated-dependencies branch July 30, 2022 05:27

carlocab mentioned this pull request Jul 30, 2022

Deprecated formulae with dependents Homebrew/homebrew-core#106902

Closed

22 tasks

github-actions bot added the outdated PR was locked due to age label Aug 30, 2022

github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

formula_auditor: audit for deprecated dependencies #12770

formula_auditor: audit for deprecated dependencies #12770

carlocab commented Jan 21, 2022

BrewTestBot commented Jan 21, 2022

Rylan12 Jan 21, 2022 •

edited

Loading

Rylan12 Jan 21, 2022 •

edited

Loading

carlocab Jul 29, 2022

BrewTestBot commented Jan 24, 2022

github-actions bot commented Feb 15, 2022

Bo98 Feb 28, 2022

SMillerDev Jul 29, 2022

carlocab Jul 29, 2022

carlocab commented Jul 29, 2022

	Dependency '#{dep.name}' is deprecated. Formulae with dependents should not be deprecated.
	Dependency '#{dep.name}' should be un-deprecated because it has dependents that are not deprecated.

	Dependency '#{dep.name}' is deprecated. Formulae with dependents should not be deprecated.
	Dependency '#{dep.name}' is deprecated but has un-deprecated dependents. Either un-deprecate '#{dep.name}' or deprecate its dependents (including '#{formula.name}).

		@@ -289,6 +289,12 @@ def audit_deps

		next unless @core_tap

		if dep_f.deprecated? && !formula.deprecated?

formula_auditor: audit for deprecated dependencies #12770

formula_auditor: audit for deprecated dependencies #12770

Conversation

carlocab commented Jan 21, 2022

BrewTestBot commented Jan 21, 2022

Rylan12 Jan 21, 2022 • edited Loading

Choose a reason for hiding this comment

Rylan12 Jan 21, 2022 • edited Loading

Choose a reason for hiding this comment

carlocab Jul 29, 2022

Choose a reason for hiding this comment

BrewTestBot commented Jan 24, 2022

github-actions bot commented Feb 15, 2022

Bo98 Feb 28, 2022

Choose a reason for hiding this comment

SMillerDev Jul 29, 2022

Choose a reason for hiding this comment

carlocab Jul 29, 2022

Choose a reason for hiding this comment

carlocab commented Jul 29, 2022

Rylan12 Jan 21, 2022 •

edited

Loading

Rylan12 Jan 21, 2022 •

edited

Loading