Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor brew cask style not to require .rubocop.yml. #1317

Merged
merged 2 commits into from
Oct 18, 2016

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Oct 18, 2016

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

Since rubocop-cask already includes a default.yml, we don't need to have a separate YAML file inside caskroom/cask. This also fixes the rare case that brew cask style fails when caskroom/cask is untapped, this is useful so we can have tests for brew cask style without having caskroom/cask tapped.

@Homebrew/cask

@reitermarkus reitermarkus added the in progress Maintainers are working on this label Oct 18, 2016
@reitermarkus reitermarkus force-pushed the refactor-rubocop-cask branch from d428fd4 to 6c118b5 Compare October 18, 2016 14:39
@reitermarkus reitermarkus force-pushed the refactor-rubocop-cask branch from 6c118b5 to 143c3ac Compare October 18, 2016 14:40
@reitermarkus
Copy link
Member Author

Had to add --config /dev/null to make sure that only rubocop-cask's default.yml is used. Not sure if there is a better/official way to force using the default configuration.

@jawshooah
Copy link
Contributor

jawshooah commented Oct 18, 2016

@reitermarkus I went ahead and asked for you: rubocop/rubocop#3647

@jawshooah jawshooah added the cask Homebrew Cask label Oct 18, 2016
@jawshooah
Copy link
Contributor

Merging for now since this works as-is, but will follow up in a separate PR if necessary once we hear back on rubocop/rubocop#3647.

@jawshooah jawshooah merged commit d08f61a into Homebrew:master Oct 18, 2016
@BrewTestBot BrewTestBot removed the in progress Maintainers are working on this label Oct 18, 2016
@reitermarkus reitermarkus deleted the refactor-rubocop-cask branch October 18, 2016 23:23
@jawshooah
Copy link
Contributor

@reitermarkus rubocop/rubocop#3658 has been merged, so once the next release is out we can replace --config /dev/null with --force-default-config.

@Homebrew Homebrew locked and limited conversation to collaborators May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cask Homebrew Cask
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants