-
-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Common-Issues: Documents resolving dual installations from Migration Assistant copies #16668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Assistant copies This is an extract and refactor of the linked Discussions post from @gromgit.
p-linnane
reviewed
Feb 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea.
Co-authored-by: Patrick Linnane <patrick@linnane.io>
…before I drop into a codespace to fight mdl
MikeMcQuaid
reviewed
Feb 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This'll add each line as a new section in the same list item and should allow the mdl check to pass.
Co-authored-by: Eric Knibbe <enk3@outlook.com> Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
p-linnane
approved these changes
Feb 16, 2024
MikeMcQuaid
approved these changes
Feb 16, 2024
Thanks @colindean! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extract and refactor of the linked Discussions post from @gromgit.
https://github.com/orgs/Homebrew/discussions/4397#discussioncomment-5567441 has been useful to at least a few people in my org this week as it’s clearly “new laptop season” and we’re hitting the ~last of the Intel Macs still in service, those put in service 2020 when my company switched wholesale to M1 macs in the 2021 refresh cycle. I expect more people to be hitting this problem en masse in the next few weeks/months as they switch architectures.
Have you written new tests for your changes? Here's an example.Have you successfully runbrew style
with your changes locally?Have you successfully runbrew typecheck
with your changes locally?Have you successfully runbrew tests
with your changes locally?