Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formula_creator: ENV.deparallelize is only for autotools #16692

Merged
merged 1 commit into from
Feb 17, 2024

Conversation

p-linnane
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This only functions for autotools, so let's not add it to all the other types of formulae.

Signed-off-by: Patrick Linnane <patrick@linnane.io>
@p-linnane p-linnane merged commit 10c50c3 into master Feb 17, 2024
24 checks passed
@p-linnane p-linnane deleted the deparallelize-only-autotools branch February 17, 2024 03:40
@carlocab
Copy link
Member

I think it works for anything that uses make?

@ZhongRuoyu
Copy link
Member

I think it works for anything that uses make?

Yea, it works with CMake in most cases too, because CMake uses Unix Makefiles as a default generator. We once had ENV.deparallelize in llvm (Homebrew/homebrew-core#138176 (comment)).

@Bo98
Copy link
Member

Bo98 commented Feb 17, 2024

It's usually harder to make bad Makefiles when CMake does a lot of it for you, so I'm impressed by those who do need it.

I guess it maybe happens to things that start bypassing CMake targets and pass flags manually.

@p-linnane
Copy link
Member Author

I can open a PR to add it to the cmake builds as well if that helps?

@Bo98
Copy link
Member

Bo98 commented Feb 17, 2024

Tbh seems better as a Formula Cookbook documentation

@MikeMcQuaid
Copy link
Member

Yeh, I'd be fine with removing from brew create altogether and instead, as @Bo98, just mention in cookbook. It's a bit of a footman given how fucking slow it makes things and is basically just an upstream bug 😭

@p-linnane
Copy link
Member Author

Opened #16701 to remove from formula_creator. It's already mentioned twice in the Formula Cookbook.

@github-actions github-actions bot added the outdated PR was locked due to age label Mar 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants