Remove CaskLoader::tap_paths.

[reitermarkus]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

Remove the last usage of CaskLoader::tap_paths.

[apainintheneck]

Code looks good and I'm happy to get rid of this. I do think that at some point it would be nice to add some more tests for some of these new cask loaders but that's non-blocking.

[reitermarkus]

There are a bunch of new tests for the new rename logic, which also implicitly test the FromDefaultNameLoader and FromNameLoader by way of testing the warning messages for renames, which really is the main difference between them. Both subclass FromTapLoader, which also already has tests.

Probably the only one missing tests is FromInstalledPathLoader. That may still already be tested using some uninstall test, as that is really the only place where this loader is relevant.

[apainintheneck]

Good point. I wasn't looking at code coverage but instead at the tap loader tests directory so I didn't think of that.

[MikeMcQuaid]

Thanks @reitermarkus for PR and @apainintheneck for the review!