Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: prune test deps of dependencies #16721

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Feb 21, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Test dependencies of test dependencies are added to missing dependencies list, e.g. In following, python@3.11 is not needed to test:

brew install zurl
==> Downloading https://ghcr.io/v2/homebrew/core/zurl/manifests/1.12.0
...brew test zurl
Error: zurl is missing test dependencies: python-setuptools python@3.11 libcython python-packaging

Need to make sure this isn't accidentally removing wanted dependencies as not familiar with recursive dependency logic.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this makes sense to me but CC @Bo98 to double check before merging.

@MikeMcQuaid MikeMcQuaid requested a review from Bo98 February 22, 2024 09:05
Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems correct, though I'm surprised we haven't hit this issue with test-bot etc?

@cho-m cho-m marked this pull request as ready for review February 22, 2024 12:11
@cho-m
Copy link
Member Author

cho-m commented Feb 22, 2024

Seems correct, though I'm surprised we haven't hit this issue with test-bot etc?

May also need to check what brew install --only-dependencies --include-test (or whatever other commands test-bot runs) is installing. It may be including more than necessary.

We've seen CI install some extra formulae deps before. Recently there were reports of this from the Python lib formulae that build multiple bindings (which we will hopefully clean up soon).

@MikeMcQuaid MikeMcQuaid merged commit 678bfec into Homebrew:master Feb 22, 2024
24 checks passed
@MikeMcQuaid
Copy link
Member

Thanks again @cho-m!

@cho-m cho-m deleted the prune-non-direct-test-deps branch March 5, 2024 02:02
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 5, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants