Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utils/github: support HOMEBREW_GITHUB_API_TOKEN with --no-fork #16751

Merged
merged 1 commit into from
Feb 27, 2024
Merged

utils/github: support HOMEBREW_GITHUB_API_TOKEN with --no-fork #16751

merged 1 commit into from
Feb 27, 2024

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Feb 26, 2024

Hopefully fixes #16747

ZhongRuoyu
ZhongRuoyu approved these changes Feb 26, 2024
View reviewed changes
Library/Homebrew/utils/github.rb Outdated Show resolved Hide resolved
ZhongRuoyu
ZhongRuoyu approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@ZhongRuoyu ZhongRuoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Bo!

@MikeMcQuaid MikeMcQuaid merged commit 6b6767b into master Feb 27, 2024
26 checks passed
@MikeMcQuaid MikeMcQuaid deleted the no-fork-yes-auth branch February 27, 2024 08:34
@MikeMcQuaid
Copy link
Member

Thanks again @Bo98!

@p-linnane p-linnane mentioned this pull request Feb 28, 2024
Merged
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 29, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ZhongRuoyu ZhongRuoyu ZhongRuoyu approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bump-formula-pr does not respect HOMEBREW_GITHUB_API_TOKEN when --no-fork is passed
3 participants
@Bo98 @MikeMcQuaid @ZhongRuoyu