Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: clear tap instance caches between test runs again #16760

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

apainintheneck
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

#16746 (comment)

The core taps exist outside of the normal cache busting cycle so they need to clear explicitly at the instance level. In theory all the other tap instances should get cleared by the class level purge of the Tap#fetch cache. Just to be sure we should clear all of them each time.

This essentially reverts a small regression in this PR.

CC: @reitermarkus

The core taps exist outside of the normal cache busting cycle
so they need to clear explicitly at the instance level.
Just to be sure we should clear all of them each time.

This essentially reverts part of the change in this PR.
- #16746
@apainintheneck apainintheneck added the critical Critical change which should be shipped as soon as possible. label Feb 28, 2024
@apainintheneck apainintheneck merged commit ece7e5d into master Feb 28, 2024
27 checks passed
@apainintheneck apainintheneck deleted the clear-taps-between-test-runs-again branch February 28, 2024 04:10
@MikeMcQuaid
Copy link
Member

Thanks again @apainintheneck!

@github-actions github-actions bot added the outdated PR was locked due to age label Mar 30, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants