Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Tap#custom_remote?. #16778

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Feb 29, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Extracted from #16730 for easier review.

@apainintheneck
Copy link
Contributor

Not sure this is really simpler.

@MikeMcQuaid
Copy link
Member

Agreed. Find this hard to follow than the previous one and doesn't reduce branching. Sorry, passing on this.

@MikeMcQuaid MikeMcQuaid closed this Mar 1, 2024
@reitermarkus
Copy link
Member Author

reitermarkus commented Mar 1, 2024

It's needed to work with the signature of Tap#remote, which is added in a later commit in the original PR.

@reitermarkus reitermarkus reopened this Mar 1, 2024
@reitermarkus
Copy link
Member Author

Feel free to suggest an alternative that only calls remote once.

@reitermarkus reitermarkus force-pushed the tap-sig-4 branch 3 times, most recently from 976e997 to d46b897 Compare March 1, 2024 12:12
@reitermarkus
Copy link
Member Author

Also note that nonzero? returns nil instead of false.

@Bo98
Copy link
Member

Bo98 commented Mar 1, 2024

Feel free to suggest an alternative that only calls remote once.

return true unless (remote = self.remote) or similar?

Library/Homebrew/tap.rb Outdated Show resolved Hide resolved
@MikeMcQuaid MikeMcQuaid merged commit 8d4e841 into Homebrew:master Mar 4, 2024
24 checks passed
@MikeMcQuaid
Copy link
Member

Thanks again @reitermarkus!

@reitermarkus reitermarkus deleted the tap-sig-4 branch March 4, 2024 15:39
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 4, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants