-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify Tap#custom_remote?
.
#16778
Simplify Tap#custom_remote?
.
#16778
Conversation
Not sure this is really simpler. |
Agreed. Find this hard to follow than the previous one and doesn't reduce branching. Sorry, passing on this. |
It's needed to work with the signature of |
Feel free to suggest an alternative that only calls |
976e997
to
d46b897
Compare
Also note that |
|
Thanks again @reitermarkus! |
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Extracted from #16730 for easier review.