language/python: add types #16799
Merged
language/python: add types #16799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add `Virtualenv` getters to get `Pathname`s to the virtualenv's `root` and `site_packages`. Signed-off-by: Michael Cho <michael@michaelcho.dev>
cho-m
force-pushed
the
language-python-add-types
branch
from
f0f430a to
383d774
Compare
apainintheneck
approved these changes
Mar 3, 2024
Comment on lines
+261
to
+264
| sig { returns(Pathname) } | ||
| def root | ||
| @venv_root | ||
| end |
There was a problem hiding this comment.
Where is this getting used?
There was a problem hiding this comment.
I originally used it in this file before adding site_packages.
I was thinking it could be used in homebrew-core rather than hardcoding path again later on, e.g. uhdm: https://github.com/Homebrew/homebrew-core/blob/master/Formula/u/uhdm.rb#L49
- "-DPython3_EXECUTABLE=#{buildpath}/venv/bin/python", *std_cmake_args
+ "-DPython3_EXECUTABLE=#{venv.root}/bin/python", *std_cmake_argsThough I can remove it if preferred as most cleanup is handled by using site_packages, e.g. qt
- venv_root = buildpath/"venv"
- venv = virtualenv_create(venv_root, python)
+ venv = virtualenv_create(buildpath/"venv", python)
venv.pip_install resources
- ENV.prepend_path "PYTHONPATH", venv_root/Language::Python.site_packages(python)
+ ENV.prepend_path "PYTHONPATH", venv.site_packagesThere was a problem hiding this comment.
No, it makes sense in that case. I was only thinking about it in the context of this file but if it can simplify the code in core then I'm all for it.
Comment on lines
-291
to
+332
| if t.respond_to? :stage | ||
| if t.is_a?(Resource) | ||
| t.stage { do_install(Pathname.pwd, build_isolation: build_isolation) } | ||
| else | ||
| t = t.lines.map(&:strip) if t.respond_to?(:lines) && t.include?("\n") | ||
| t = t.lines.map(&:strip) if t.is_a?(String) && t.include?("\n") |
There was a problem hiding this comment.
This checks out.
brew(main):004:0> [String, Pathname, Resource].select { _1.instance_methods.include? :lines }
=> [String]
brew(main):005:0> [String, Pathname, Resource].select { _1.instance_methods.include? :stage }
=> [Resource]
Bo98
approved these changes
Mar 4, 2024
MikeMcQuaid
approved these changes
Mar 4, 2024
|
Thanks again |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add
Virtualenvgetters to getPathnames to the virtualenv'srootandsite_packages.brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?