-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev-cmd/bump: skip autobump formulae & casks #16833
Conversation
This is a good idea, though it should probably be the default behaviour without any switch involved, no? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with @Bo98: makes sense but should be default behaviour with no documented opt-out flag (but the undocumented environment variable for our internal usage).
Instead output a message that corresponding formula/cask is on the autobump list. This avoids deferring the information to the error message within `bump-{formula,cask}-pr`. Signed-off-by: Michael Cho <michael@michaelcho.dev>
027df89
to
12d1e56
Compare
--skip-autobump
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks again @cho-m!
# Whether this {Tap} allows running bump commands on the given {Formula} or {Cask}. | ||
sig { params(formula_or_cask_name: String).returns(T::Boolean) } | ||
def allow_bump?(formula_or_cask_name) | ||
ENV["HOMEBREW_TEST_BOT_AUTOBUMP"].present? || !official? || autobump.exclude?(formula_or_cask_name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could maybe just read GITHUB_ACTOR
or similar here to avoid having to carry around an extra environment variable in our workflows.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Not sure how useful, but can allow bypassing autobumped formulae/casks in scenarios like running without args or when running with
--installed
, e.g.