Remove FromDefaultNameLoader to avoid warning twice.

[reitermarkus]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

This fixes the duplicate warning when trying to load a migrated formula/cask using a short token.

Note: This does not yet fix the warning being shown when loading both formulae/casks at the same time, despite the migrated-to formula/cask existing.

[bevanjkay]

Because we aren't (to my knowledge) currently storing what tap a cask/formula is installed from, am I correct in understanding the warnings will show up every time a token is referenced for as long as it exists in a tap_migrations file?

[reitermarkus]

Yes, as long as it is in tap_migrations, it will show a warning.

Currently there is still another bug: For example, brew info go will currently show a cask warning, despite the go formula existing. The cask warning in this case should really only show up when --cask is specified.

[bevanjkay]

In general, should the warning only show if the migration is not found?

[reitermarkus]

Whether or not it is found doesn't matter. The warning should only show if the user explicitly specified the thing that was migrated, in the go example that would be either

homebrew/cask/go

or

--cask go

but not

go

by itself.

[MikeMcQuaid]

Thanks again @reitermarkus!