Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rubocops/service: allow require_root to be used without run. #16914

Merged
merged 2 commits into from
Mar 20, 2024
Merged

rubocops/service: allow require_root to be used without run. #16914

merged 2 commits into from
Mar 20, 2024

Conversation

MikeMcQuaid
Copy link
Member

Fixes #16908

apainintheneck
apainintheneck reviewed Mar 20, 2024
View reviewed changes
Copy link
Contributor

@apainintheneck apainintheneck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A RuboCop spec should be added to make sure that this now supported use case stays supported. The docs should also get updated as well.

@MikeMcQuaid
Copy link
Member Author

The docs should also get updated as well.

Done.

A RuboCop spec should be added to make sure that this now supported use case stays supported.

No existing tests covered name so there's no specs to be adjusted. A bunch could be added but I don't think that's worth blocking a user issue on.

@MikeMcQuaid MikeMcQuaid enabled auto-merge March 20, 2024 08:31
@MikeMcQuaid MikeMcQuaid merged commit 91d670c into master Mar 20, 2024
25 checks passed
@MikeMcQuaid MikeMcQuaid deleted the service_require_root_no_run branch March 20, 2024 08:42
@Jerry1144 Jerry1144 mentioned this pull request Mar 20, 2024
Merged
7 tasks
@p-linnane
Copy link
Member

@KissMyPixel I'm not sure why you are dropping random comments on a bunch of PR's in our repo's today, but please stop. Thanks.

@apainintheneck apainintheneck mentioned this pull request Mar 21, 2024
Merged
7 tasks
@Jerry1144 Jerry1144 mentioned this pull request Apr 16, 2024
Merged
6 tasks
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 20, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@apainintheneck apainintheneck apainintheneck left review comments

@p-linnane p-linnane p-linnane approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

brew audit: allow require_root to exist independent of run in service do blocks
3 participants
@MikeMcQuaid @p-linnane @apainintheneck