Skip to content

bump-formula-pr: fix type of detected version #16920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Conversation

EricFromCanada
Copy link
Member

@EricFromCanada EricFromCanada commented Mar 19, 2024

Relates to recent type signature additions, e.g. in #16886. Fixes #16917.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@EricFromCanada
Copy link
Member Author

Error is unrelated:

 Error: GitHub::search_issues queries GitHub issues with the passed parameters

Failure/Error: expect(results.first["title"]).to eq("Shall we run `brew update` automatically?")

  expected: "Shall we run `brew update` automatically?"
       got: "Shall we move more things to taps?"

Copy link
Contributor

@apainintheneck apainintheneck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That error got fixed on the master branch so this should be good to go after a rebase.

@EricFromCanada EricFromCanada merged commit e3de11a into master Mar 20, 2024
@EricFromCanada EricFromCanada deleted the fix-version-type branch March 20, 2024 03:00
@MikeMcQuaid
Copy link
Member

Thanks @EricFromCanada!

@github-actions github-actions bot added the outdated PR was locked due to age label Apr 20, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bump-formula-pr fails with Parameter 'version': Expected type T.nilable(String), got type Version with value #<Version:0x0000000107fe472...0.2"
4 participants