-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
formula_auditor: audit redis
relicense
#16928
Conversation
Would it make more sense to generalize the logic here so that it's not specific to |
I considered it, but opted for just getting it added. There's also one for Elasticsearch/Kibana though...so maybe it's about time. |
Yeah, I think it's time. It shouldn't be that difficult. Just remove hashicorp from the names of methods and constants and add the new formula-version pair to the hash. Also, could you fix this typo while you're in this file? brew/Library/Homebrew/formula_auditor.rb Line 508 in 7b2bfee
|
Signed-off-by: Patrick Linnane <patrick@linnane.io>
Signed-off-by: Patrick Linnane <patrick@linnane.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning up the audit!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks for the PR @p-linnane and for the nice suggestion @apainintheneck!
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Redis has made the unfortunate decision to relicense under a non-OSI license. This PR sets up an audit to prevent Redis from being updated to the relicensed version.