Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formula_auditor: audit redis relicense #16928

Merged
merged 2 commits into from
Mar 21, 2024
Merged

formula_auditor: audit redis relicense #16928

merged 2 commits into from
Mar 21, 2024

Conversation

p-linnane
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Redis has made the unfortunate decision to relicense under a non-OSI license. This PR sets up an audit to prevent Redis from being updated to the relicensed version.

@apainintheneck
Copy link
Contributor

Would it make more sense to generalize the logic here so that it's not specific to redis? We already do something similar when auditing Hashicorp formulae so maybe they can be combined into a more generic audit_relicensed_formulae check.

@p-linnane
Copy link
Member Author

I considered it, but opted for just getting it added. There's also one for Elasticsearch/Kibana though...so maybe it's about time.

@apainintheneck
Copy link
Contributor

Yeah, I think it's time. It shouldn't be that difficult. Just remove hashicorp from the names of methods and constants and add the new formula-version pair to the hash.

Also, could you fix this typo while you're in this file?

"vagrant-compleion" => "2.4",

Signed-off-by: Patrick Linnane <patrick@linnane.io>
Signed-off-by: Patrick Linnane <patrick@linnane.io>
Copy link
Contributor

@apainintheneck apainintheneck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up the audit!

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks for the PR @p-linnane and for the nice suggestion @apainintheneck!

@MikeMcQuaid MikeMcQuaid merged commit 59c894a into master Mar 21, 2024
25 checks passed
@MikeMcQuaid MikeMcQuaid deleted the redis-audit branch March 21, 2024 11:42
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants