language/*: enable typed: strict

[cho-m]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

[issyl0]

Is it worth saying this is a future intended deprecation (in a comment above) otherwise it might be confusing for people combing through deprecations.

[MikeMcQuaid]

@issyl0 This is how we normally handle "deprecate this next major/minor release" deprecations.

[issyl0]

Ah, thanks for the clarification!

[reitermarkus]

Maybe we can reword this somehow? Otherwise we end up with

use or request upstream to migrate to Go modules instead.

[cho-m]

I was originally either going to leave it empty or thinking of just Go modules (i.e. use Go modules instead)

I partly mixed in another related message from:

brew/Library/Homebrew/rubocops/text.rb

Line 117 in 9ae5161

problem "`go_resource`s are deprecated. Please ask upstream to implement Go vendoring"

[cho-m]

I can do any extra updates to deprecation message in a separate PR and also add comment for go_resources. May just go with something like:

Suggested change

	# odeprecated "Language::Go::stage_deps", "or request upstream to migrate to Go modules"
	# odeprecated "Language::Go::stage_deps", "Go modules"

In case of existing message, as I understand, vendoring would also refer to older solution with vendor directory and GOPATH, which we are also trying to get rid of.

[cho-m]

I guess another option is to recommend: Language::Go::stage_deps --> resources.each { |r| (target/r.name).install r} and go_resource --> resource. Though, this means the formula is still using an old approach.

I have used these to get rid of all usage of go_resources in Homebrew/core.

[MikeMcQuaid]

@issyl0 This is how we normally handle "deprecate this next major/minor release" deprecations.

[MikeMcQuaid]

Looks good, thanks again @cho-m!