Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable and fix RSpec/DescribedClassModuleWrapping #16979

Merged
merged 4 commits into from
Mar 31, 2024
Merged

Conversation

dduugg
Copy link
Member

@dduugg dduugg commented Mar 30, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

When porting the dev cmds to use the AbstractCommand interface, I noticed that audit_spec contained tests for classes defined in other files, namely FormulaAuditor and FormulaTextAuditor. I've moved those to separate files, according to our usual conventions. I also flipped on RSpec/DescribedClassModuleWrapping and resolved the corresponding violations, which makes this pattern less likely to recur (bc we also don't allow multiple top-level describe blocks in files).

I've also enabled RSpec/FilePath at SpecSuffixOnly, although there were no violations (it requires spec file names to end with _spec.

@dduugg dduugg merged commit 221fde4 into master Mar 31, 2024
25 checks passed
@dduugg dduugg deleted the rspec-cleanup branch March 31, 2024 01:16
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 30, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants