Enable and fix RSpec/DescribedClassModuleWrapping #16979
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?When porting the dev cmds to use the AbstractCommand interface, I noticed that
audit_spec
contained tests for classes defined in other files, namelyFormulaAuditor
andFormulaTextAuditor
. I've moved those to separate files, according to our usual conventions. I also flipped onRSpec/DescribedClassModuleWrapping
and resolved the corresponding violations, which makes this pattern less likely to recur (bc we also don't allow multiple top-leveldescribe
blocks in files).I've also enabled
RSpec/FilePath
atSpecSuffixOnly
, although there were no violations (it requires spec file names to end with_spec
.