Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make more token types work as $HOMEBREW_GITHUB_API_TOKEN #17001

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

PikachuEXE
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Similar to #16983

Closes #17000

Tokens of different token type(s) can be generated in GitHub Workflows by GitHub Apps

See doc & blog about token types
https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/about-authentication-to-github#githubs-token-formats https://github.blog/2021-04-05-behind-githubs-new-authentication-token-formats/

brew tests failed before I make any change

Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@carlocab carlocab merged commit 0b39a87 into Homebrew:master Apr 2, 2024
25 checks passed
@MikeMcQuaid
Copy link
Member

Thanks @PikachuEXE, great work!

@PikachuEXE PikachuEXE deleted the patch-1 branch April 2, 2024 12:30
@github-actions github-actions bot added the outdated PR was locked due to age label May 3, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support GitHub App installation access tokens
3 participants