Enable RSpec/DescribeClass #17015
Merged
Enable RSpec/DescribeClass #17015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dduugg
commented
Apr 3, 2024
| @@ -1,25 +0,0 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| RSpec.describe "conflicts_with", :cask do | |||
There was a problem hiding this comment.
It seemed weird to have this in its own file – I moved this to dsl_spec, where there are similar tests.
| @@ -2,7 +2,9 @@ | |||
|
|
|||
| # TODO: this test should be named after the corresponding class, once | |||
| # that class is abstracted from installer.rb | |||
| # rubocop:disable RSpec/DescribeClass | |||
There was a problem hiding this comment.
This would resolve with the TODO above it.
| @@ -229,15 +229,3 @@ def formula(name = "formula_name", path: Formulary.core_path(name), spec: :stabl | |||
| end.to raise_error(BuildError) | |||
| end | |||
| end | |||
|
|
|||
| __END__ | |||
MikeMcQuaid
reviewed
Apr 3, 2024
MikeMcQuaid
approved these changes
Apr 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?Follow-up to https://github.com/Homebrew/brew/pull/16815/files#r1518269399
Disabling this cop made sense, when we would have had ~100 command spec files using
Homebrew, but now they're each individually namespaced.There are still a few stray files that don't make sense to spec under a class. For the most part, I used the escape hatch of labeling them
type: system. That's arguably too esoteric though, and perhaps I should justrubocop:disablethem instead (but i consider the latter to be a bit of an eyesore). Feedback welcome.