Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manpages: move requires after install_bundler_gems! #17036

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Apr 5, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

May need confirmation these are only needed inside regenerate_man_pages.

Verified

This commit was signed with the committer’s verified signature.
cho-m Michael Cho
Signed-off-by: Michael Cho <michael@michaelcho.dev>
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @cho-m!

@MikeMcQuaid MikeMcQuaid enabled auto-merge April 5, 2024 16:22
@MikeMcQuaid MikeMcQuaid merged commit e55f9e5 into Homebrew:master Apr 5, 2024
25 checks passed
@cho-m cho-m deleted the manpages-defer-require branch April 5, 2024 16:34
@github-actions github-actions bot added the outdated PR was locked due to age label May 6, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants