dev-cmd/tap-new: various improvements #17110
Conversation
It should be `github.repository_owner` rather than `github.actor`.
1. Update `actions/cache` to `v4`. 2. Unset GitHub Packages tokens if unused. 3. Quote shell variables.
Library/Homebrew/dev-cmd/tap-new.rb
Outdated
| HOMEBREW_GITHUB_PACKAGES_TOKEN: #{args.github_packages? ? "${{ github.token }}" : "null"} | ||
| HOMEBREW_GITHUB_PACKAGES_USER: #{args.github_packages? ? "${{ github.repository_owner }}" : "null"} |
There was a problem hiding this comment.
What's the advantage in using null here?
There was a problem hiding this comment.
Sort of similar to how fine-grained tokens are configured, I think it's preferred not to set an environment variable when it's not needed. Though, technically this should already have been restricted via the permissions above with packages: none.
There was a problem hiding this comment.
This is skill going to set the variable but just to a null value which seems weird. Nicer to make the output of both of these a single conditional perhaps?
There was a problem hiding this comment.
This is skill going to set the variable but just to a
nullvalue which seems weird.
It's actually null really, because it's interpreted as a YAML null.
Nicer to make the output of both of these a single conditional perhaps?
ea37708 should hopefully make it better by not setting those variables at all.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?actions/upload-artifact@v4andactions/cache@v4.github.repository_ownerrather thangithub.actor.