Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Follow-up to #17934
This PR addresses a few additional VS Code configuration things.
First, the Ruby LSP configuration now runs
brew install-bundler-gems --add-groups=style,typecheck,vscode
before starting the LSP. This should automatically install everything and keep the LSP up to date for new users.Additionally,
editor.formatOnType
is now turned on forruby
files. This handles a few things, but a big one is that it will automatically addend
statements and handle indents. This removes the need for thekaiwood.endwise
VS Code plugin, so I have removed it.Finally, this PR adds the
--lsp
option tobrew typecheck
which allows us to actually enable the Sorbet plugin and view live type info (much of the code here comes from @Bo98).