Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More VS Code improvements #17942

Merged
merged 5 commits into from
Aug 2, 2024
Merged

More VS Code improvements #17942

merged 5 commits into from
Aug 2, 2024

Conversation

Rylan12
Copy link
Member

@Rylan12 Rylan12 commented Aug 2, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Follow-up to #17934

This PR addresses a few additional VS Code configuration things.

First, the Ruby LSP configuration now runs brew install-bundler-gems --add-groups=style,typecheck,vscode before starting the LSP. This should automatically install everything and keep the LSP up to date for new users.

Additionally, editor.formatOnType is now turned on for ruby files. This handles a few things, but a big one is that it will automatically add end statements and handle indents. This removes the need for the kaiwood.endwise VS Code plugin, so I have removed it.

Finally, this PR adds the --lsp option to brew typecheck which allows us to actually enable the Sorbet plugin and view live type info (much of the code here comes from @Bo98).

Copy link
Member

@issyl0 issyl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic!

Library/Homebrew/dev-cmd/typecheck.rb Outdated Show resolved Hide resolved
Co-authored-by: Bo Anderson <mail@boanderson.me>
@Rylan12 Rylan12 enabled auto-merge August 2, 2024 23:20
@Rylan12 Rylan12 merged commit 6cfa083 into master Aug 2, 2024
25 checks passed
@Rylan12 Rylan12 deleted the vscode-updates branch August 2, 2024 23:31
@MikeMcQuaid
Copy link
Member

Great work, thanks @Rylan12!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants