Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type comparison for gh #18031

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

pmartindev
Copy link

@pmartindev pmartindev commented Aug 12, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Casting gh_version to a string prior to comparison to resolve the mismatched type error.
CleanShot 2024-08-12 at 15 37 31

Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pmartindev! One suggestion, and I think it'd also be good to have a test here.

(If you don't feel like doing the test, just let me know and I'll commit it to your branch.)

Library/Homebrew/attestation.rb Outdated Show resolved Hide resolved
Co-authored-by: William Woodruff <william@yossarian.net>
@pmartindev
Copy link
Author

Thanks @woodruffw! I'm happy to add the test with your guidance, or you can feel free to add it 😃 Are you looking for the same test you implemented in #17926 , or an additional test against the version?

Copy link

github-actions bot commented Sep 4, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Sep 4, 2024
@woodruffw woodruffw removed the stale No recent activity label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants