-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
formula_auditor: reject more SPDX licenses #18035
Conversation
May also be worth doing a pass over |
I agree. Honestly, I think We should have an attitude of "only include open source software and, if in doubt, exclude" rather than "if in doubt, include". |
On my todo list. Already have some (like
That is the ideal, but SPDX is not ready for that given some important software like DocBook is still pending license identifiers. Fedora seems to be doing a large scale legal cleanup and have contributed a number of SPDX updates, which has helped reduce some of our On Homebrew side, the next step would be to take any |
Sounds great, thanks @cho-m! |
Also require licenses on non-disabled formulae
Should be ready for review now. I've added a short list of examples. May extract this to JSON in future for easier updates. Sadly Debian has no master list. Fedora has one which can be fetched by us, but they have slightly different opinions compared to DFSG (e.g. |
Also require licenses on non-disabled formulae
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?I am working on adding licenses to all non-disabled formulae, so opening PR to make some license checks stricter.
The extra licenses are only some examples for now (too much effort to make exhaustive), e.g.
BUSL-1.1
andElastic-2.0
are ones we have manually rejected in Homebrew/core. For now, just reject all versions (can modify if terms change)CC-BY-NC
I believe are going to be non-free due to non-commercial restrictionCC-BY-NC-SA
example - https://wiki.debian.org/DFSGLicenses#Creative_Commons_Attribution-NonCommercial-ShareAlike_.28CC_BY-NC-SA.29CC-BY-NC-*
licenses. They do allowCC-BY-ND-x.y
for "Allowed content". See https://docs.fedoraproject.org/en-US/legal/allowed-licenses/JSON
is non-free pretty much everywhere - https://wiki.debian.org/qa.debian.org/jsonevilCould consider out-sourcing lists but not sure if there is one that fully matches our preferences.
Fedora has their own list but no idea on what their legal requirements are - https://docs.fedoraproject.org/en-US/legal/not-allowed-licenses/