Exclude sorbet assignments from Style/MutableConstant cop

[dduugg]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

We can't do anything about these violations, and the rubocop:disable comments are a bit of an eyesore. How would folks feel about excluding such patterns from the Style/MutableConstant cop instead? (If folks are amenable, I can then flesh this out with tests and such.)

[MikeMcQuaid]

Approach makes sense to me, thanks!

[Bo98]

Good idea. Though might be worth considering upstreaming this to rubocop-sorbet which also has a Style/MutableConstant extension? T::Enum is another case (though not one used by Homebrew/brew yet).

[dduugg]

Good idea. Though might be worth considering upstreaming this to rubocop-sorbet which also has a Style/MutableConstant extension? T::Enum is another case (though not one used by Homebrew/brew yet).

Great suggestion, I've opened Shopify/rubocop-sorbet#256
I don't understand the T::Enum case (I've only used it as a superclass), so I didn't include a pattern for that one.

[Bo98]

Great suggestion, I've opened Shopify/rubocop-sorbet#256 I don't understand the T::Enum case (I've only used it as a superclass), so I didn't include a pattern for that one.

See https://github.com/Homebrew/ci-orchestrator/blob/f643ab875fbd9695072333fe2de17c98eb98cd8a/src/priority_type.rb as an example

[dduugg]

Closing this, pending outcome of upstream PR