Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-cmd/bottle: include installed_size in metadata #18144

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Aug 23, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Could be useful for approximating installations, like what apt and other package managers show.

Or adding bottle and approximate install size on https://formulae.brew.sh

@cho-m cho-m marked this pull request as ready for review August 23, 2024 22:51
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea!

@MikeMcQuaid MikeMcQuaid merged commit 70e777c into Homebrew:master Aug 26, 2024
24 checks passed
@cho-m cho-m deleted the installed_size branch August 26, 2024 12:36
@cho-m cho-m mentioned this pull request Aug 26, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants