-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
utils/spdx: fix invalid SPDX syntax for symbols #18169
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, thanks @cho-m!
65e6e4e
to
66d25a5
Compare
Also use more common uppercase operators for backwards compatibility
66d25a5
to
82fbbcc
Compare
Updated to use For public domain, if any identifier becomes well adopted, then we can consider switching. Currently, it is all over the place:
|
Thanks again @cho-m! |
Also use more common uppercase operators for backwards compatibility.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?https://spdx.github.io/spdx-spec/v2.3/SPDX-license-expressions/#d1-overview - Spaces are invalid (e.g.
Cannot Represent
) and non-official SPDX entries must at least haveLicenseRef-
(could also haveDocumentRef-<name>:LicenseRef-
but I doubt we would ever need this in Homebrew).SPDX expressions operators should be case-sensitive uppercase - https://spdx.github.io/spdx-spec/v2.3/SPDX-license-expressions/#d2-case-sensitivity
(In PR, for backwards compatibility with existing JSON API, need to match both for now).EDIT: Lowercase is allowed in newer spec, but uppercase is more common so okay either way but switching seems better for compatibility.WITH
allows for a compound expression