Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about auditor to How-To-Open-a-Homebrew-Pull-Request.md #18189

Merged
merged 9 commits into from
Aug 30, 2024

Conversation

jrschumacher
Copy link
Contributor

@jrschumacher jrschumacher commented Aug 29, 2024

During my submission I followed this guide since it is the first link, but it wasn't until we got to the end of the process that I learned I should have created a tap.

This was a great experience for me, but a waste of maintainers time.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@jrschumacher
Copy link
Contributor Author

@MikeMcQuaid mind giving it another review. I skimmed some old PRs, and it looks like the shared audit is also run for casks (although if a cask doesn't have a social code registry associated, it looks like that step might be skipped 🤷).

Let me know if any other changes are needed.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think we need to have specific audit output in here, thanks!

docs/How-To-Open-a-Homebrew-Pull-Request.md Outdated Show resolved Hide resolved
docs/How-To-Open-a-Homebrew-Pull-Request.md Outdated Show resolved Hide resolved
jrschumacher and others added 2 commits August 29, 2024 08:48
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jrschumacher!

Copy link
Member

@ZhongRuoyu ZhongRuoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jrschumacher! I suggest using URLs from https://docs.brew.sh/ instead because that's where we expect people to read docs (rather than here in the repo).

docs/How-To-Open-a-Homebrew-Pull-Request.md Outdated Show resolved Hide resolved
docs/How-To-Open-a-Homebrew-Pull-Request.md Outdated Show resolved Hide resolved
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs/How-To-Open-a-Homebrew-Pull-Request.md Outdated Show resolved Hide resolved
docs/How-To-Open-a-Homebrew-Pull-Request.md Outdated Show resolved Hide resolved
jrschumacher and others added 2 commits August 29, 2024 15:54
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
Co-authored-by: Ruoyu Zhong <zhongruoyu@outlook.com>
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

One suggestion; this should fix the CI failure.

docs/How-To-Open-a-Homebrew-Pull-Request.md Outdated Show resolved Hide resolved
Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ZhongRuoyu ZhongRuoyu merged commit 67398c7 into Homebrew:master Aug 30, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants