-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note about auditor to How-To-Open-a-Homebrew-Pull-Request.md #18189
Conversation
@MikeMcQuaid mind giving it another review. I skimmed some old PRs, and it looks like the shared audit is also run for casks (although if a cask doesn't have a social code registry associated, it looks like that step might be skipped 🤷). Let me know if any other changes are needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think we need to have specific audit output in here, thanks!
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jrschumacher!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jrschumacher! I suggest using URLs from https://docs.brew.sh/ instead because that's where we expect people to read docs (rather than here in the repo).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
Co-authored-by: Ruoyu Zhong <zhongruoyu@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
One suggestion; this should fix the CI failure.
Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
During my submission I followed this guide since it is the first link, but it wasn't until we got to the end of the process that I learned I should have created a tap.
This was a great experience for me, but a waste of maintainers time.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?