Adjust typing around #check_pull_requests #18217
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?brew bump-formula-pr
is encountering a type error (e.g., as seen in a recent homebrew/core autobump run), as the inferred return type ofGitHub#check_for_duplicate_pull_requests
doesn't align with the explicit return type of#check_pull_requests
:This addresses the issue by adding a type signature with a
void
return type to#check_for_duplicate_pull_requests
and setting the return type of#check_pull_requests
tovoid
as well. The return type from#check_pull_requests
isn't used, so avoid
return type is arguably a better reflection of the method's behavior. The#check_pull_requests
method inBumpCaskPr
has avoid
return type, so this change brings theBumpFormulaPr
method in line.