Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SyntaxError introduced by a refactor in bc0f5ee #18221

Merged
merged 1 commit into from
Sep 1, 2024

Conversation

blazczak
Copy link
Contributor

@blazczak blazczak commented Sep 1, 2024

Fixes the syntax error introduced by an incomplete refactor in bc0f5ee

$ brew update
==> Updating Homebrew...
To restore the stashed changes to /usr/local/Homebrew, run:
  cd /usr/local/Homebrew && git stash pop
  File "<string>", line 1
    import fcntl; fcntl.flock(, fcntl.LOCK_EX | fcntl.LOCK_NB)
                              ^
SyntaxError: invalid syntax

Caused by missed variable rename in bc0f5ee

The fix finishes the refactor by completing the variable rename and brings the code base back to a (more) consistent state.

  • [✓] Have you followed the guidelines in our Contributing document?
  • [✓] Have you checked to ensure there aren't other open Pull Requests for the same change?
  • [✓] Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • [✓] Have you successfully run brew style with your changes locally?
  • [✓] Have you successfully run brew typecheck with your changes locally?
  • [✓] Have you successfully run brew tests with your changes locally?

$ brew update
==> Updating Homebrew...
To restore the stashed changes to /usr/local/Homebrew, run:
  cd /usr/local/Homebrew && git stash pop
  File "<string>", line 1
    import fcntl; fcntl.flock(, fcntl.LOCK_EX | fcntl.LOCK_NB)
                              ^
SyntaxError: invalid syntax

Introduced on May 2, 2024 with Homebrew@bc0f5ee
Copy link
Member

@ZhongRuoyu ZhongRuoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching and fixing this, @blazczak!

@ZhongRuoyu ZhongRuoyu merged commit 33f53dd into Homebrew:master Sep 1, 2024
27 checks passed
@MikeMcQuaid
Copy link
Member

Whoops, thanks @blazczak!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants